Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10125 fix DefaultCodegen parsing to handle 'uniqueItems' flag #10154

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

akshpan
Copy link
Contributor

@akshpan akshpan commented Apr 5, 2020

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This fix helps DefaultCodegen handle uniqueitems flag for query parameters. For body parameters the issue is fixed by PR#10490

@akshpan akshpan marked this pull request as ready for review February 1, 2021 17:17
@akshpan
Copy link
Contributor Author

akshpan commented Feb 2, 2021

@HugoMario Hello, this fix is to handle "uniqueitems" tag for query paramters. PR#10490 fixes this only for body parameters.

@HugoMario
Copy link
Contributor

LGTM. Thanks a lot @akshpan !!

@HugoMario HugoMario merged commit a4b766b into swagger-api:master Feb 6, 2021
@akshpan akshpan deleted the issue-10125 branch February 6, 2021 13:00
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants