PHP 7.2 #8534
Merged
PHP 7.2 #8534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some rules around whitespace have been disabled, since we don't have a great deal of control over whitespace that is emitted when template values are empty.
|
Can someone please merge this pull request, it is still an issue! |
|
Just wanted to pass on that we were able to get this pull request merged with the OpenAPI project over at OpenAPITools/openapi-generator#769. I'm a user of both OpenAPI and this project, and would love to see PHP7.2 support for my v2 spec clients! Please don't hesitate to reach out if I can be of any assistance. |
|
thanks a lot @mattmelling!!! |
|
Why wasn't this bundled in any of the 3.0.* releases? |
|
@HugoMario we use cli v3.20, still the same problem any answer how, which executable to use without having this issue? |
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixes #8533. The PHP client uses
friendsofphp/php-cs-fixerv1.12 for PSR2 analysis. 1,12 doesn't supports PHP up to < 7.2.PHP >= 7.2 support was added in
php-cs-fixerv2 which made some changes to the API and default fixers/rules.This PR upgrades
php-cs-fixerto v2.12. The fixers/rules have been aligned for PSR2 as desired in the original PR (#3863). I've changed defaults for some of the rules to prevent lots of whitespace warnings fromphp-cs-fixer, these typically seem to be down to blank template values and are not raised when using the configuration in master.Notes
php-cs-fixeradded the idea of "risky" fixers in v2. Since thestrict_paramandstrict_comparisonfixers are considered risky, we must alter the command line tovendor/bin/php-cs-fixer fix --dry-run --diff -vvv --allow-risky yeseven when using --dry-run./cc @dkarlovi, @mandrean