Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): change copy to clipboard button location #9111

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

char0n
Copy link
Member

@char0n char0n commented Aug 2, 2023

Refs #8465
Refs #8153
Refs #8131


This PR uses changes from #8465 and retains keyboard navigation. "black outline that appears on focus" has been retained, and chevron icon has been made not navigable as it would be redundant and anoying.

swagger-ui-keyboard-navigation-suggestion.mp4

@char0n char0n self-assigned this Aug 2, 2023
@char0n char0n changed the title fix(ui): change copy to cliboard button location fix(ui): change copy to clipboard button location Aug 2, 2023
@thinkjson
Copy link

Looks good to me!

@char0n char0n merged commit 377b54a into master Aug 16, 2023
6 checks passed
@char0n char0n deleted the char0n/copy-cliboard-location branch August 17, 2023 13:08
char0n pushed a commit that referenced this pull request Sep 22, 2023
…and icons (#9230)

The goal if to have collapse/expand icon always 
in the extreme right possition.

Refs #9111
@remcolam
Copy link

I am using version 6.5 and I still have the jumping layout on hover. How can I get rid of this bad UX behaviour?

@char0n
Copy link
Member Author

char0n commented Feb 15, 2024

Hi @remcolam,

There is no version 6.5. Latest version of SwaggerUI is https://github.com/swagger-api/swagger-ui/releases/tag/v5.11.4

@remcolam
Copy link

🤦 I was confusing the swagger ui with the package I use in my application to add swagger... Thank you for your reaction. Will check if I can update the UI in it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants