Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPCO hardcoded to 0.9 in pl_waterup.f90 #28

Open
jenskiesel opened this issue Nov 26, 2024 · 1 comment
Open

EPCO hardcoded to 0.9 in pl_waterup.f90 #28

jenskiesel opened this issue Nov 26, 2024 · 1 comment

Comments

@jenskiesel
Copy link

I noticed that EPCO is not sensitive. Is there a reason why EPCO is set to 0.9 in this line:

swatplus/src/pl_waterup.f90

Line 134 in 344efc6

pcom(j)%plcur(ipl)%epco = 0.9

Can I remove this line and commit?
@tugraskan
Copy link
Collaborator

Yes, this can be removed. I discussed it with Dr. Arnold, and it was hardcoded for national run testing purposes instead of using pl_prms calibration values because low values in it were causing errors. I will also remove this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jenskiesel @tugraskan