Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information #99

Closed
minus7 opened this issue Aug 20, 2015 · 7 comments
Closed

Add version information #99

minus7 opened this issue Aug 20, 2015 · 7 comments

Comments

@minus7
Copy link
Contributor

minus7 commented Aug 20, 2015

The --version command line switch as well as the get_version IPC command (see #98) could use this information. Should probably generated at compile time.

i3 IPC version information includes:

{
    "human_readable": "4.10.3-347-g586854b (2015-07-30, branch \"makepkg\")",
    "major": 4,
    "minor": 10,
    "patch": 3
}
@ddevault
Copy link
Contributor

Yeah, we need to figure out how to make cmake read the git tags (and also start tagging versions). Blocked until I decide to mark the first version of sway.

@ddevault
Copy link
Contributor

@Luminarys @minus7 IPC reminder

@minus7
Copy link
Contributor Author

minus7 commented Aug 26, 2015

IPC taken care of, just needs to be patched up with better version information.

@ddevault
Copy link
Contributor

For the sake of everyone who isn't on IRC, sway will start being versioned once wlc starts being versioned.

@Luminarys
Copy link
Collaborator

I'll work on improving the version information later tonight. Do you still want to do everything through macros defined at compile time?

@ddevault
Copy link
Contributor

Yep.

@Luminarys
Copy link
Collaborator

I'm closing this for the time being, as the output is now essentially the same as i3's with the exception of the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants