-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
@@ -127,14 +127,19 @@ | |||
|
|||
<request name="set_exclusive_zone"> | |||
<description summary="configures the exclusive geometry of this surface"> | |||
Requests that the compositor avoids occluding an area of the surface | |||
with other surfaces. The compositor's use of this information is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be interpreted as meaning an exclusive zone larger than the surface should be ignored. If this is intentional, it should be explicitly specified. I'm assuming that is not the meaning.
edge or an edge and both perpendicular edges. If the surface is not | ||
anchored, anchored to only two perpendicular edges (a corner), anchored | ||
to only two parallel edges or anchored to all edges, a positive value | ||
will be treated the same as zero. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be a protocol error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Would require a version bump, and can be done separately)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an opinion on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A protocol error would be nice for a future patch, agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean it will be required to set the exclusive zone to zero in the same commit as you change the anchor to one that does not allow an exclusive zone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would make sense
to only two parallel edges or anchored to all edges, a positive value | ||
will be treated the same as zero. | ||
|
||
A positive zone is the number of surface-local coordinates to consider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative wording: "distance from the edge in surface-local coordinates"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better
Edit: done
Thanks! |
Describe under what anchors the exclusive zone has an effect.