Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Clearify exclusive zone #43

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Apr 12, 2019

Describe under what anchors the exclusive zone has an effect.

@@ -127,14 +127,19 @@

<request name="set_exclusive_zone">
<description summary="configures the exclusive geometry of this surface">
Requests that the compositor avoids occluding an area of the surface
with other surfaces. The compositor's use of this information is
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be interpreted as meaning an exclusive zone larger than the surface should be ignored. If this is intentional, it should be explicitly specified. I'm assuming that is not the meaning.

edge or an edge and both perpendicular edges. If the surface is not
anchored, anchored to only two perpendicular edges (a corner), anchored
to only two parallel edges or anchored to all edges, a positive value
will be treated the same as zero.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be a protocol error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Would require a version bump, and can be done separately)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an opinion on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A protocol error would be nice for a future patch, agreed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean it will be required to set the exclusive zone to zero in the same commit as you change the anchor to one that does not allow an exclusive zone?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would make sense

to only two parallel edges or anchored to all edges, a positive value
will be treated the same as zero.

A positive zone is the number of surface-local coordinates to consider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative wording: "distance from the edge in surface-local coordinates"

Copy link
Contributor Author

@wmww wmww Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better
Edit: done

@emersion emersion requested a review from ddevault July 5, 2019 14:24
@ddevault ddevault merged commit 59497d9 into swaywm:master Jul 5, 2019
@ddevault
Copy link
Contributor

ddevault commented Jul 5, 2019

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants