Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Clearify exclusive zone #43

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Clearify exclusive zone #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c95809
Clearify under what conditions the exclusive zone has an effect
wmww Apr 12, 2019
cf5e57b
number of [coordinates] -> distance from the edge
wmww Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions unstable/wlr-layer-shell-unstable-v1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,19 @@

<request name="set_exclusive_zone">
<description summary="configures the exclusive geometry of this surface">
Requests that the compositor avoids occluding an area of the surface
with other surfaces. The compositor's use of this information is
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be interpreted as meaning an exclusive zone larger than the surface should be ignored. If this is intentional, it should be explicitly specified. I'm assuming that is not the meaning.

Requests that the compositor avoids occluding an area with other
surfaces. The compositor's use of this information is
implementation-dependent - do not assume that this region will not
actually be occluded.

A positive value is only meaningful if the surface is anchored to an
edge, rather than a corner. The zone is the number of surface-local
coordinates from the edge that is considered exclusive.
A positive value is only meaningful if the surface is anchored to one
edge or an edge and both perpendicular edges. If the surface is not
anchored, anchored to only two perpendicular edges (a corner), anchored
to only two parallel edges or anchored to all edges, a positive value
will be treated the same as zero.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be a protocol error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Would require a version bump, and can be done separately)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an opinion on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A protocol error would be nice for a future patch, agreed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean it will be required to set the exclusive zone to zero in the same commit as you change the anchor to one that does not allow an exclusive zone?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would make sense


A positive zone is the distance from the edge in surface-local
coordinates to consider exclusive.

Surfaces that do not wish to have an exclusive zone may instead specify
how they should interact with surfaces that do. If set to zero, the
Expand Down