fix(es/resolver): Handle TsInterfaceDecl and UsingDecl correctly

[l4yton]

Related issue:

• Closes: TypeScript identifier resolver incorrectly handles block scopes #7967

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[l4yton]

This should fix the issue, but I'm not sure how to properly add tests for this.

[kdy1]

First of all, thank you for the contribution!

For testing, you can add a file named input.js to somewhere in https://github.com/swc-project/swc/tree/35fb6528f54b11192dd967297294cdc1852aa57b/crates/swc_ecma_transforms_base/tests/ts-resolver and run UPDATE=1 cargo test from your terminal.

Note that you may need to touch https://github.com/swc-project/swc/blob/35fb6528f54b11192dd967297294cdc1852aa57b/crates/swc_ecma_transforms_base/tests/ts_resolver.rs

[kdy1]

Also, can you sign the CLA?

[l4yton]

Sure, will sign the CLA. Just noticed that this fix doesn't work if typescript is true when using resolver(Mark::new(), Mark::new(), true), though it does if it's false...

[kdy1]

I requested review from other team members because I'm not sure about the changes

[Austaras]

This looks fine. What concerns you?

[kdy1]

Thank you!

---

swc-bump:

• swc_ecma_transforms_base

[kdy1]

Removal of this logic seems dangerous to me at that time, but now I'm not sure why I feel it dangerous.

[swc-bot]

Automated review comment generated by auto-rebase script