fix(es/ast): Add definite and is_override to AutoAccessor
#8436
Conversation
crates/swc_ecma_codegen/src/lib.rs
Outdated
| if n.accessibility != Some(Accessibility::Public) { | ||
| self.emit_accessibility(n.accessibility)?; | ||
| } | ||
| self.emit_accessibility(n.accessibility)?; |
There was a problem hiding this comment.
This will internally handle whether to emit the accessibility or not (it's better if we emit the AST as-is as it allows someone to add public keywords if they'd like to and this change aligns this node with the other nodes).
|
Edit: Oh, maybe I only thought it worked this way because the CI was actually failing on the dep check. Edit 2: Ah, this does sometimes still error asking for a bump comment. |
dsherret
changed the title
definite to AutoAccessordefinite and is_override to AutoAccessor
|
I'll merge this into a new branch named |
**Description:** Adds a `definite` and `is_override` property to `AutoAccessor` as they were missing. It also fixes codegen for `AutoAccessor` when emitting TypeScript (which is the main reason I need this PR). **BREAKING CHANGE:** Adds a `definite` and `is_override` property. **Related issue:** - Closes #8344
Description:
Adds a
definiteandis_overrideproperty toAutoAccessoras they were missing.Also fixes codegen for
AutoAccessorwhen emitting TypeScript (which is the main reason I need this PR).BREAKING CHANGE:
Adds a
definiteandis_overrideproperty.Related issue (if exists):
Closes #8344