Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Emit implements clause with commas #8477

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Jan 2, 2024

Description:

Emitting implements was missing commas.

Related issue (if exists): None

@dsherret dsherret requested a review from a team as a code owner January 2, 2024 18:38
@dsherret
Copy link
Contributor Author

dsherret commented Jan 2, 2024

It seems one of the swc_ecma_minifier tests is flaky. I also had this fail then pass on the other PR.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 enabled auto-merge (squash) January 3, 2024 04:04
@kdy1 kdy1 self-assigned this Jan 3, 2024
@kdy1 kdy1 added this to the Planned milestone Jan 3, 2024
@kdy1 kdy1 added the automerge label Jan 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kdy1 kdy1 added the S-approved label Jan 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@CLAassistant
Copy link

CLAassistant commented Jan 3, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ kdy1
✅ dsherret
✅ swc-bot
❌ kodiakhq[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kdy1
✅ dsherret
❌ kodiakhq[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit d98a282 into swc-project:main Jan 3, 2024
141 checks passed
@dsherret dsherret deleted the fix_implements_comma_delimited branch January 3, 2024 22:10
@@ -143,7 +143,7 @@ bitflags! {
| Self::SpaceBetweenSiblings.bits()
| Self::SpaceBetweenBraces.bits();
const MultiLineFunctionBodyStatements = Self::MultiLine.bits();
const ClassHeritageClauses = Self::SingleLine.bits() | Self::SpaceBetweenSiblings.bits();
const ClassHeritageClauses = Self::CommaDelimited.bits() | Self::SingleLine.bits() | Self::SpaceBetweenSiblings.bits();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one will actually be fixed via a bump of swc_ecma_ast.

@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 15, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants