-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/codegen): Emit implements clause with commas #8477
fix(es/codegen): Emit implements clause with commas #8477
Conversation
It seems one of the swc_ecma_minifier tests is flaky. I also had this fail then pass on the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_codegen
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
@@ -143,7 +143,7 @@ bitflags! { | |||
| Self::SpaceBetweenSiblings.bits() | |||
| Self::SpaceBetweenBraces.bits(); | |||
const MultiLineFunctionBodyStatements = Self::MultiLine.bits(); | |||
const ClassHeritageClauses = Self::SingleLine.bits() | Self::SpaceBetweenSiblings.bits(); | |||
const ClassHeritageClauses = Self::CommaDelimited.bits() | Self::SingleLine.bits() | Self::SpaceBetweenSiblings.bits(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one will actually be fixed via a bump of swc_ecma_ast.
Description:
Emitting
implements
was missing commas.Related issue (if exists): None