Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Emit declare keyword for class properties #8478

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Jan 2, 2024

Description:

Emits the declare keyword in class properties.

Related issue (if exists): None

@dsherret dsherret requested a review from a team as a code owner January 2, 2024 20:32
kdy1
kdy1 previously approved these changes Jan 3, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 added the automerge label Jan 3, 2024
@kdy1 kdy1 added this to the Planned milestone Jan 3, 2024
@kdy1 kdy1 self-assigned this Jan 3, 2024
@kdy1 kdy1 enabled auto-merge (squash) January 3, 2024 04:04
Copy link

kodiakhq bot commented Jan 3, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Jan 3, 2024
@kdy1 kdy1 added the automerge label Jan 3, 2024
Copy link

kodiakhq bot commented Jan 3, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Jan 3, 2024
auto-merge was automatically disabled January 3, 2024 05:12

Head branch was pushed to by a user without write access

@dsherret
Copy link
Contributor Author

dsherret commented Jan 3, 2024

Fixed conflict in output.min.js file.

@dsherret dsherret requested a review from kdy1 January 3, 2024 05:13
@kdy1 kdy1 enabled auto-merge (squash) January 3, 2024 05:39
@kdy1 kdy1 added the automerge label Jan 3, 2024
@kdy1 kdy1 merged commit 2076ef8 into swc-project:main Jan 3, 2024
277 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 15, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants