Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/compat): Correctly handle this in arrow function parameters #8489

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari changed the title fix(es/compat): this in arrow function parameters should refer to the outer scope fix(es/compat): this in arrow function parameters Jan 9, 2024
@magic-akari magic-akari marked this pull request as ready for review January 9, 2024 10:07
@magic-akari magic-akari requested a review from a team as a code owner January 9, 2024 10:07
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!



swc-bump:

  • swc_ecma_compat_es2015
  • swc_ecma_preset_env

@kdy1 kdy1 changed the title fix(es/compat): this in arrow function parameters fix(es/compat): Correctly handle this in arrow function parameters Jan 9, 2024
@kdy1 kdy1 enabled auto-merge (squash) January 9, 2024 10:09
@kdy1 kdy1 added this to the Planned milestone Jan 9, 2024
@kdy1 kdy1 added the automerge label Jan 9, 2024
@kdy1 kdy1 merged commit 52a8f05 into swc-project:main Jan 9, 2024
275 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 15, 2024
@magic-akari magic-akari deleted the fix/issue-8488 branch February 4, 2024 02:38
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Wrong transform result on method default parameter that access class member with optional chaining.
2 participants