Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/systemjs): Handle top level this #8506

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix(es/systemjs): Handle top level this #8506

merged 2 commits into from
Jan 16, 2024
+64 −30

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari marked this pull request as ready for review January 15, 2024 14:40
@magic-akari magic-akari requested a review from a team as a code owner January 15, 2024 14:40
kdy1
kdy1 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_module

@kdy1 kdy1 enabled auto-merge (squash) January 16, 2024 03:08
swc-bot
swc-bot reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 0f94c8c into swc-project:main Jan 16, 2024
142 checks passed
@kdy1 kdy1 added this to the v1.3.104 milestone Jan 19, 2024
@magic-akari magic-akari deleted the fix/issue-8505 branch February 4, 2024 02:38
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.104
Development

Successfully merging this pull request may close these issues.

SystemJS constructors drop all references to this and replace with void 0
3 participants
@magic-akari @kdy1 @swc-bot