-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/helpers): Fix metadata of decorators being undefined
#8768
fix(es/helpers): Fix metadata of decorators being undefined
#8768
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you revert changes in swc_ecma_transforms_base
?
What, pray, is the meaning of this? I only modified this file(packages/helpers/esm/_apply_decs_2203_r.js) and added the missing variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misread it. Sorry.
Please modify https://github.com/swc-project/swc/blob/b798632a829eca950ede021d3e2db57f8649523c/crates/swc_ecma_transforms_base/src/helpers/_apply_decs_2203_r.js, too
This file is correct and there is no missing variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- dbg-swc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
when use "decorator stage3" with this option that
context.metadata
will beundefined
if set
externalHelpers
tofalse
,context.metadata
is rightexample code