Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Use Str.raw for es5 #8873

Merged
merged 11 commits into from
Apr 23, 2024
Merged

fix(es/codegen): Use Str.raw for es5 #8873

merged 11 commits into from
Apr 23, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 18, 2024 •
edited
Loading

@kdy1 kdy1 added this to the Planned milestone Apr 18, 2024
@kdy1 kdy1 self-assigned this Apr 18, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5c206c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 commented Apr 22, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 changed the title fix(es/transforms): Preserve Str.raw while es2015 => es5 test(es/es2015): Preserve Str.raw while es2015 => es5 Apr 22, 2024
@kdy1 kdy1 marked this pull request as ready for review April 22, 2024 03:31
@kdy1 kdy1 requested a review from a team as a code owner April 22, 2024 03:31
kodiakhq[bot]
kodiakhq bot previously approved these changes Apr 22, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) April 22, 2024 03:31
swc-bot
swc-bot reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 changed the title test(es/es2015): Preserve Str.raw while es2015 => es5 fix(es/codegen): Preserve Str.raw while es2015 => es5 Apr 22, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Apr 22, 2024
View reviewed changes
kdy1
kdy1 commented Apr 22, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_codegen

@kdy1 kdy1 changed the title fix(es/codegen): Preserve Str.raw while es2015 => es5 fix(es/codegen): Use Str.raw for es5 Apr 22, 2024
@kdy1 kdy1 disabled auto-merge April 22, 2024 05:34
@kdy1 kdy1 enabled auto-merge (squash) April 22, 2024 05:34
@kdy1 kdy1 disabled auto-merge April 22, 2024 05:55
@kdy1 kdy1 requested a review from a team as a code owner April 22, 2024 06:06
@kdy1
Copy link
Member Author

kdy1 commented Apr 22, 2024

Same here, I'll wait for reviews because I'm not confident.

@kdy1 kdy1 enabled auto-merge (squash) April 23, 2024 01:26
swc-bot
swc-bot reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge April 23, 2024 01:48
@kdy1 kdy1 merged commit c7a06b1 into swc-project:main Apr 23, 2024
148 of 289 checks passed
@kdy1 kdy1 deleted the issue-8871 branch April 23, 2024 01:48
@kdy1 kdy1 modified the milestones: Planned, v1.4.17 Apr 23, 2024
@LingyuCoder LingyuCoder mentioned this pull request May 9, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.17
Development

Successfully merging this pull request may close these issues.

swc removes the backslash "\" when target is "es5" even if "minify" option is not set
2 participants
@kdy1 @swc-bot