Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minifier removes side effects from accessing getter with numeric string key #9500

Closed
hyp3rflow opened this issue Aug 26, 2024 · 1 comment · Fixed by #9530
Closed

Minifier removes side effects from accessing getter with numeric string key #9500

hyp3rflow opened this issue Aug 26, 2024 · 1 comment · Fixed by #9530
Labels
Milestone

Comments

@hyp3rflow
Copy link
Contributor

Describe the bug

Accessing getter property with numeric/numeric string key should be tracked as side-effect expression and prevent expressions to inline/remove.

Input code

let foo = 1;
const obj = {
    get 1() { // same with get "1"()
        foo = 2;
        return 40;
    },
};
obj["1"]; // same with obj[1]
console.log(foo);

Config

{
  "jsc": {
    "parser": {
      "syntax": "ecmascript",
      "jsx": false
    },
    "target": "es2022",
    "loose": false,
    "minify": {
      "compress": {
        "arguments": false,
        "arrows": true,
        "booleans": true,
        "booleans_as_integers": false,
        "collapse_vars": true,
        "comparisons": true,
        "computed_props": true,
        "conditionals": true,
        "dead_code": true,
        "directives": true,
        "drop_console": false,
        "drop_debugger": true,
        "evaluate": true,
        "expression": false,
        "hoist_funs": false,
        "hoist_props": true,
        "hoist_vars": false,
        "if_return": true,
        "join_vars": true,
        "keep_classnames": false,
        "keep_fargs": true,
        "keep_fnames": false,
        "keep_infinity": false,
        "loops": true,
        "negate_iife": true,
        "properties": true,
        "reduce_funcs": false,
        "reduce_vars": false,
        "side_effects": true,
        "switches": true,
        "typeofs": true,
        "unsafe": false,
        "unsafe_arrows": false,
        "unsafe_comps": false,
        "unsafe_Function": false,
        "unsafe_math": false,
        "unsafe_symbols": false,
        "unsafe_methods": false,
        "unsafe_proto": false,
        "unsafe_regexp": false,
        "unsafe_undefined": false,
        "unused": true,
        "const_to_let": true,
        "pristine_globals": true
      },
      "mangle": false
    }
  },
  "module": {
    "type": "es6"
  },
  "minify": false,
  "isModule": true
}

Playground link (or link to the minimal reproduction)

https://play.swc.rs/?version=1.7.18&code=H4sIAAAAAAAAA8tJLVFIy89XsFUwtOZKzs8rLlHIT8oCcqu5FIAgHShtqKEJ5YEARLGRNVygKLWktChPwcQAIlSrw1VrzQU0I1rJUCkWYmZ%2BTqpeTn66BlCvpjUAF1iYX3IAAAA%3D&config=H4sIAAAAAAAAA32UO3LjMAyG%2B5zCozrFjostcoDtcgYOTYIyvXxoCNCxJuO7L0TJj40hdRI%2B%2FAAJgPh%2B2%2B26E5ruY%2FfNn%2Fwz6IJQ7v9swTGRvrClAxM1muIH6t5v9IQTcjogNNN1Jh3p0gM1Fe5%2F7feLogs5I9wUiy365N34nNPkOBRAfLKxlUPWCInwf%2F3CSv6aAJX6bD%2FkHECnDaI0Kp8IeihSYJND0AOCOusiRJlOqovHLKWYYCWwaih5EHmynnxOnPOVWtBWmWxBQL6AIX8GSca5WJaQryfcp2ELh9r3rc8%2F1HDWoWoScsKltYRPK0Q9Zo%2BkXE1SCWe4UoMZLsX9qfROFaBa0qvulH1a6clfAK5A0IhJR5DiNg%2FH87SmdptKnxyPLI0C5%2FmWbpmg56Iq751Q2akyUMhL3Sxgq4GpskY6zoJXyofeggLneFaE0PjlyRylpDQOkJ0AuL%2FaSVM1A3V%2FhSt8ehAb%2BA%2FfkuQBWzyipuM6xTEecthIEIGO2W44cCsor%2BPCW%2BIyrPOaLPBogBVdKjbwugT4AVBWoe3Ll9ng58ERVR%2Fy4bEmFofrfQ9HnfrHe59X8dvi0MVsa4PLkp%2F6O6%2Fm393D6baF7wfvPH7elC3p9R%2BoYzQdMAYAAA%3D%3D

SWC Info output

No response

Expected behavior

should not be inlined

Actual behavior

No response

Version

1.7.18

Additional context

No response

@kdy1 kdy1 assigned kdy1 and unassigned kdy1 Aug 27, 2024
@kdy1 kdy1 added this to the Planned (Low priority) milestone Aug 27, 2024
@kdy1 kdy1 assigned kdy1 and unassigned kdy1 Aug 28, 2024
@kdy1 kdy1 closed this as completed in #9530 Sep 4, 2024
@kdy1 kdy1 closed this as completed in 8513816 Sep 4, 2024
@kdy1 kdy1 modified the milestones: Planned (Low priority), Planned Sep 4, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.7.24 Sep 8, 2024
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 9, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

5 participants
@kdy1 @hyp3rflow @swc-bot and others