@swc/wasm-typescript exits on Windows arm64 when fed with certain syntax #9520

wojtekmaj · 2024-08-31T22:32:52Z

Describe the bug

After investigation in nodejs/node#54645 I finally came to conclusion that on Windows arm64 (this particular configuration, not Windows other than arm64, not arm64 other than Windows), swc fails to transform certain syntax and just silently exits instead.

Input code

export function foo() {
	if (false) {
	}
	return 'foo';
};

Config

n/a

Playground link (or link to the minimal reproduction)

https://gist.github.com/wojtekmaj/c37e1eb07676cde83e5201ade8b7f02f

SWC Info output

Operating System:
    Platform: win32
    Arch: arm64
    Machine Type: unknown
    Version: Windows 11 Home
    CPU: (12 cores)
        Models: Snapdragon(R) X 12-core X1E80100 @ 3.40 GHz

Binaries:
    Node: 22.7.0
    npm: N/A
    Yarn: N/A
    pnpm: N/A

Relevant Packages:
    @swc/core: N/A
    @swc/helpers: N/A
    @swc/types: N/A


SWC Config:
    output: N/A
    .swcrc path: N/A

Next.js info:
    output: N/A

Expected behavior

Code should be transformed, types should be stripped, swc should not silently exit.

Actual behavior

swc silently exists, and neither the output, nor "End 2" console.log (see playground link) never appears on the screen.

Version

1.7.22

Additional context

No response

The text was updated successfully, but these errors were encountered:

magic-akari · 2024-09-06T09:34:48Z

Is this issue only related to the strip-only?
You can check it by adding the option mode: "transform" as shown below:

import { transformSync } from "@swc/wasm-typescript";

const options = {
	mode: "transform",
	transform: {
		verbatimModuleSyntax: true,
		nativeClassProperties: true,
		noEmptyExport: true,
		importNotUsedAsValues: "preserve",
	}
}

console.log("Begin 1");
console.log(
	transformSync(`
export function foo() {
	return 'foo';
};
`, options).code,
);
console.log("End 1");

console.log("Begin 2");
console.log(
	transformSync(`
export function foo() {
	if (false) {
	}
	return 'foo';
};
`, options).code,
);
console.log("End 2");

wojtekmaj · 2024-09-06T17:56:53Z

@magic-akari No luck:

PS C:\test> node swc.js 
Begin 1
export function foo() {
    return 'foo';
}

End 1
Begin 2

magic-akari · 2024-09-06T18:00:06Z

It's suspected that the issue arises at an earlier stage, possibly in the parser.

wojtekmaj · 2024-09-06T18:04:47Z

It's my first encounter with swc, so apologies if my diagnosis so far aren't the best, but I'll do my best to help out. The hardware is yours to experiment on :D

magic-akari · 2024-09-07T05:43:43Z

let's do more experiments to pinpoint this issue.

Test the strip-only mode in your browser by clicking this link:
https://play.swc.rs/?version=1.7.23&code=H4sIAAAAAAAAA0utKMgvKlFIK81LLsnMz1NIy8%2FX0FSo5uLMTFPQSEvMKU4F82q5OItSS0qL8hTUgSrUrblqrQGZRHv4OgAAAA%3D%3D&config=H4sIAAAAAAAAA6vmUlBQyipOVrJSqAYygZyCxKLi1CI4HyhSXJlXklgBFFFKTc5NLE4uyiwoUQJL1nKBcC0ABwZxP0UAAAA%3D&strip-types=
Check the parser's functionality in your browser using this link:
https://swc-ast.vercel.app/#code/KYDwDg9gTgLgBAMwK4DsDGMCWEWIhACgEo4BvAKAEhME4CEBDAGwGdgSLKBfKqYGJFFwByBPmEBuclwlA
Run this command to verify the parser's functionality in Node:

npx swc_ast_viewer path/to/your_file.js

wojtekmaj · 2024-09-11T09:01:25Z

@magic-akari

Ad 1 - This worked perfectly fine, on latest Microsoft Edge, arm64 build. input === output.
Ad 2 - This resulted in the following output (no crash):

Output


Module(
    Module {
        span: 1..59,
        body: [
            ModuleDecl(
                ExportDecl(
                    ExportDecl {
                        span: 1..58,
                        decl: Fn(
                            FnDecl {
                                ident: Ident {
                                    span: 17..20,
                                    ctxt: #2,
                                    sym: "foo",
                                    optional: false,
                                },
                                declare: false,
                                function: Function {
                                    params: [],
                                    decorators: [],
                                    span: 8..58,
                                    ctxt: #3,
                                    body: Some(
                                        BlockStmt {
                                            span: 23..58,
                                            ctxt: #3,
                                            stmts: [
                                                If(
                                                    IfStmt {
                                                        span: 26..41,
                                                        test: Lit(
                                                            Bool(
                                                                Bool {
                                                                    span: 30..35,
                                                                    value: false,
                                                                },
                                                            ),
                                                        ),
                                                        cons: Block(
                                                            BlockStmt {
                                                                span: 37..41,
                                                                ctxt: #4,
                                                                stmts: [],
                                                            },
                                                        ),
                                                        alt: None,
                                                    },
                                                ),
                                                Return(
                                                    ReturnStmt {
                                                        span: 43..56,
                                                        arg: Some(
                                                            Lit(
                                                                Str(
                                                                    Str {
                                                                        span: 50..55,
                                                                        value: "foo",
                                                                        raw: Some(
                                                                            "'foo'",
                                                                        ),
                                                                    },
                                                                ),
                                                            ),
                                                        ),
                                                    },
                                                ),
                                            ],
                                        },
                                    ),
                                    is_generator: false,
                                    is_async: false,
                                    type_params: None,
                                    return_type: None,
                                },
                            },
                        ),
                    },
                ),
            ),
            Stmt(
                Empty(
                    EmptyStmt {
                        span: 58..59,
                    },
                ),
            ),
        ],
        shebang: None,
    },
)

Ad 3 - This just prints the version number, regardless of the file I'm feeding it (!):

PS C:\test> npx swc_ast_viewer ./simple-file.ts
swc@0.103.1

magic-akari · 2024-09-11T09:37:41Z

It seems that our WASM version parser isn't working on Windows ARM64 with Node.js.
The lack of error messages from WASM, which just exits quietly, complicates debugging.

Moreover, there are no methods in WASM that trigger process.exit, and I think that exiting silently is an unexpected behavior in Node.js.

What are your thoughts? @kdy1

marco-ippolito · 2024-09-11T09:50:03Z

My feeling is that there is no crash/error, it simply exits the transpilation early with an empty output.
Github recently released arm64 windows runner, we could use that to reproduce.

kdy1 · 2024-09-11T11:20:19Z

@magic-akari I think we can use the CI of SWC. You can add some node.js tests and run the publish action with only nightly enabled.
I'll do it soon.

kdy1 · 2024-09-11T11:26:33Z

Let's try with @swc/core first.
I made #9547 and triggered https://github.com/swc-project/swc/actions/runs/10810667484

marco-ippolito · 2024-09-16T08:43:23Z

Let's try with @swc/core first.
I made #9547 and triggered https://github.com/swc-project/swc/actions/runs/10810667484

I see the CI is green, might be related to WASM?

kdy1 · 2024-09-16T08:54:20Z

I got an arm64 windows device. My mother had one 👍
I'll fix this issue after Chuseok holiday(through Wednesday)

kdy1 · 2024-09-20T02:18:12Z

I managed to install VS and rust on it. I'll try later today.

kdy1 · 2024-09-21T06:06:17Z

Running cargo test in swc_fast_ts_strip. If it works I'll try --release and the input specified

kdy1 · 2024-09-21T15:23:42Z

cargo test and cargo test --release works properly for the specified input.
cc @magic-akari What should we do? I think it's a bug of wasm-bindgen

magic-akari · 2024-09-22T03:00:23Z

cargo test and cargo test --release works properly for the specified input. cc @magic-akari What should we do? I think it's a bug of wasm-bindgen

However, the same WASM works in the browser but not in node.
You can check the glue code of swc_ast_viewer: https://www.npmjs.com/package/swc_ast_viewer?activeTab=code

marco-ippolito · 2024-10-18T15:38:42Z

I've tried with newer versions and the problem persists. Just to confirm, is the bug in the javascript wasm glue or in the wasm itself?

kdy1 · 2024-10-20T09:41:42Z

Actually, I don't remember. I'll retry and report back.

kdy1 · 2024-10-22T01:58:38Z

My notebook is somehow broken, so I think I should try using some hosting

kdy1 · 2024-10-23T07:01:26Z

Installing...

kdy1 · 2024-10-23T11:43:02Z

I managed to run it and it worked.

$ node -v
v20.18.0

$ wasm-pack -V
wasm-pack 0.13.0

$ rustc -vV
rustc 1.83.0-nightly (55a22d2a6 2024-10-06)
binary: rustc
commit-hash: 55a22d2a63334e0faff0202b72a31ce832b56125
commit-date: 2024-10-06
host: aarch64-pc-windows-msvc
release: 1.83.0-nightly
LLVM version: 19.1.1

kdy1@WIN-PQAP3GH9V16 CLANGARM64 ~/Desktop/projects/swc/bindings/binding_typescript_wasm (main)
$ cargo -vV
cargo 1.83.0-nightly (ad074abe3 2024-10-04)
release: 1.83.0-nightly
commit-hash: ad074abe3a18ce8444c06f962ceecfd056acfc73
commit-date: 2024-10-04
host: aarch64-pc-windows-msvc
libgit2: 1.8.1 (sys:0.19.0 vendored)
libcurl: 8.9.0-DEV (sys:0.4.74+curl-8.9.0 vendored ssl:Schannel)
os: Windows 10.0.26100 (Windows 11 Professional) [64-bit]

Can you share the exact node.js version that failed?

kdy1 · 2024-10-23T11:48:36Z

Also, End 2 is printed.

marco-ippolito · 2024-10-23T11:57:43Z

This is the PR that can reproduce this behavior
nodejs/node#54657
It should be reproducible on node 22.10.0
Can you use transformSync and add the same settings we use on node?
https://github.com/nodejs/amaro/blob/main/src%2Ftransform.ts#L4

kdy1 · 2024-10-24T00:24:06Z

Hmmm... It worked. It may be an OS bug, or a bug of one of the libraries between OS and our runtime. But I'll try the published version first.

kdy1 · 2024-10-24T00:34:23Z

Well... It worked.

CPU bug
OS bug
Bug in somewhere that is not triggered by windows 11

wojtekmaj · 2024-10-24T07:06:27Z

Can my real machine be of any use?

kdy1 · 2024-10-31T08:19:27Z

@wojtekmaj Steps to reproduce:

Install rustup
Install wasm-pack
git clone https://github.com/swc-project/swc.git -b swc-win-arm64
cd ./swc
yarn
cd ./bindings/binding_typescript_wasm
./scripts/build.sh
node nodejs-patched.mjs

Can you try it?

wojtekmaj · 2024-10-31T12:30:26Z

I'm stuck on build phase :/ Getting

= note: rust-lld: error: could not open 'msvcrt.lib': no such file or directory␍

despite installing the dependencies as documented...

kdy1 · 2024-12-08T06:21:11Z

@marco-ippolito I created a separate repository to test it using Github Actions.
Repo: https://github.com/kdy1/swc-win-arm64

I'll monitor this to ensure that it does not fail with unrelated stuffs

kdy1 · 2024-12-08T07:28:18Z

It seems like napi default template does not have arm64 windows.
cc @Brooooooklyn Is there a good way to test napi binding on arm64 windows?

Brooooooklyn · 2024-12-08T07:53:26Z

@kdy1 https://github.com/kdy1/swc-win-arm64/actions/runs/12219567059/job/34086308398 The binary was built, but the GitHub Actions doesn't provide Windows on ARM runner, so I think it's hard to setup Windows on ARM test

kwonoj · 2024-12-17T17:03:02Z

I'll try to see if I can repro this.

marco-ippolito · 2024-12-23T20:28:12Z

Apparently it now works on Node nodejs/node#54645 I assume it was some weird combination of v8/windows arm64

wojtekmaj · 2024-12-23T23:45:36Z

Unfortunately, this is not my experience. I updated @swc/wasm-typescript in my original repro from 1.7.23 to 1.10.1 and this is still very much reproducible, with SWC quietly exiting:

PS C:\test> node swc.js 
Begin 1
export function foo() {
    return 'foo';
}

End 1
Begin 2

marco-ippolito · 2024-12-24T06:00:11Z

Unfortunately, this is not my experience. I updated @swc/wasm-typescript in my original repro from 1.7.23 to 1.10.1 and this is still very much reproducible, with SWC quietly exiting:
PS C:\test> node swc.js 
Begin 1
export function foo() {
    return 'foo';
}

End 1
Begin 2

Can you try with Node 23?

marco-ippolito · 2024-12-24T07:24:49Z

On Node main and v23.5.0 (Windows 11 arm64 VM I got on azure):
(stripTypeScriptTypes) is basically a wrapper around transformSync

// test.swc.js
import { stripTypeScriptTypes } from "node:module";

console.log("Begin 1");
console.log(
	stripTypeScriptTypes(`
export function foo() {
	return 'foo';
};
`),
);
console.log("End 1");

console.log("Begin 2");
console.log(
	stripTypeScriptTypes(`
export function foo() {
	if (false) {
	}
	return 'foo';
};
`),
);
console.log("End 2");

Output:

PS C:\Users\satanacchio\Desktop\projects\node> out\Release\node.exe test.swc.js
Begin 1

export function foo() {
        return 'foo';
};

End 1
Begin 2

export function foo() {
        if (false) {
        }
        return 'foo';
};

End 2

Output on Node 23.5.0:

PS C:\Users\satanacchio\Desktop\projects\node> .\node-23-5-0.exe test.swc.js
Begin 1

export function foo() {
        return 'foo';
};

End 1
Begin 2

export function foo() {
        if (false) {
        }
        return 'foo';
};

End 2

Also the interaction with loaders has been fixed.
I would consider this fixed on Node 23.5.0.
I think it was due to some bug in v8 or some weird interaction.

Brooooooklyn · 2024-12-24T08:35:56Z

@marco-ippolito I suggest you verify that the output of process.arch under Node.js in your ARM64 VM is arm64. It is easy to accidentally install the x64 version on a Windows arm64 system.

marco-ippolito · 2024-12-24T08:39:34Z

@marco-ippolito I suggest you verify that the output of process.arch under Node.js in your ARM64 VM is arm64. It is easy to accidentally install the x64 version on a Windows arm64 system.

It is arm 100%

wojtekmaj added the C-bug label Aug 31, 2024

avivkeller mentioned this issue Aug 31, 2024

On Windows arm64 TS-based custom loader sometimes causes the process to exit silently when used with --experimental-strip-types nodejs/node#54645

Closed

kdy1 added this to the Planned milestone Sep 1, 2024

wojtekmaj changed the title ~~@swc/wasm-typescript exists on Windows arm64 when fed with certain syntax~~ @swc/wasm-typescript exits on Windows arm64 when fed with certain syntax Sep 1, 2024

kdy1 self-assigned this Sep 3, 2024

mcollina mentioned this issue Nov 13, 2024

Unflag --experimental-strip-types nodejs/typescript#17

Open

6 tasks

kwonoj self-assigned this Dec 17, 2024

@swc/wasm-typescript exits on Windows arm64 when fed with certain syntax #9520

@swc/wasm-typescript exits on Windows arm64 when fed with certain syntax #9520

Comments

wojtekmaj commented Aug 31, 2024 • edited Loading

Describe the bug

Input code

Config

Playground link (or link to the minimal reproduction)

SWC Info output

Expected behavior

Actual behavior

Version

Additional context

magic-akari commented Sep 6, 2024

wojtekmaj commented Sep 6, 2024

magic-akari commented Sep 6, 2024

wojtekmaj commented Sep 6, 2024 • edited Loading

magic-akari commented Sep 7, 2024

wojtekmaj commented Sep 11, 2024 • edited Loading

magic-akari commented Sep 11, 2024

marco-ippolito commented Sep 11, 2024

kdy1 commented Sep 11, 2024

kdy1 commented Sep 11, 2024

marco-ippolito commented Sep 16, 2024

kdy1 commented Sep 16, 2024 • edited Loading

kdy1 commented Sep 20, 2024

kdy1 commented Sep 21, 2024

kdy1 commented Sep 21, 2024 • edited Loading

magic-akari commented Sep 22, 2024

marco-ippolito commented Oct 18, 2024

kdy1 commented Oct 20, 2024

kdy1 commented Oct 22, 2024

kdy1 commented Oct 23, 2024

kdy1 commented Oct 23, 2024

kdy1 commented Oct 23, 2024

marco-ippolito commented Oct 23, 2024 • edited Loading

kdy1 commented Oct 24, 2024

kdy1 commented Oct 24, 2024 • edited Loading

wojtekmaj commented Oct 24, 2024

kdy1 commented Oct 31, 2024

wojtekmaj commented Oct 31, 2024

kdy1 commented Dec 8, 2024 • edited Loading

kdy1 commented Dec 8, 2024

Brooooooklyn commented Dec 8, 2024

kwonoj commented Dec 17, 2024

marco-ippolito commented Dec 23, 2024

wojtekmaj commented Dec 23, 2024

marco-ippolito commented Dec 24, 2024

marco-ippolito commented Dec 24, 2024 • edited Loading

Brooooooklyn commented Dec 24, 2024

marco-ippolito commented Dec 24, 2024 • edited Loading

wojtekmaj commented Aug 31, 2024 •

edited

Loading

wojtekmaj commented Sep 6, 2024 •

edited

Loading

wojtekmaj commented Sep 11, 2024 •

edited

Loading

kdy1 commented Sep 16, 2024 •

edited

Loading

kdy1 commented Sep 21, 2024 •

edited

Loading

marco-ippolito commented Oct 23, 2024 •

edited

Loading

kdy1 commented Oct 24, 2024 •

edited

Loading

kdy1 commented Dec 8, 2024 •

edited

Loading

marco-ippolito commented Dec 24, 2024 •

edited

Loading

marco-ippolito commented Dec 24, 2024 •

edited

Loading