Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/renamer): Check preserved in normal renaming mode #9666

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix(es/renamer): Check preserved in normal renaming mode #9666

merged 3 commits into from
Oct 22, 2024
+49 −1

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented Oct 21, 2024 •
edited
Loading

Description: check preserved in normal renaming mode

BREAKING CHANGE:

Related issue (if exists):
fix #9663

@unbyte unbyte requested a review from a team as a code owner October 21, 2024 12:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a2f96cc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@unbyte unbyte requested a review from a team as a code owner October 21, 2024 12:23
@unbyte unbyte changed the title fix: preserved symbols are renamed fix(es/renamer): check preserved in normal renaming mode Oct 21, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9666 will improve performances by 3.86%

Comparing unbyte:fix/eval-rename (50b7051) with main (f70b842)

Summary

⚡ 1 improvements
✅ 193 untouched benchmarks

Benchmarks breakdown

Benchmark main unbyte:fix/eval-rename Change
⚡ es/full/bugs-1 550.9 µs 530.4 µs +3.86%

kdy1
kdy1 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 added this to the Planned milestone Oct 22, 2024
@unbyte
Copy link
Contributor Author

unbyte commented Oct 22, 2024

Wow, I couldn't find any documentation on how to generate changesets in swc repository. I eventually found knope based on the commit history. It seems that my generated changeset doesn't include crates info. How should I generate an appropriate changeset for my next contribution?

@kdy1 kdy1 changed the title fix(es/renamer): check preserved in normal renaming mode fix(es/renamer): Check preserved in normal renaming mode Oct 22, 2024
@kdy1 kdy1 mentioned this pull request Oct 22, 2024
Merged
@kdy1
Copy link
Member

kdy1 commented Oct 22, 2024

I added documentation for it with #9667! Thank you for leaving a comment. I don't know the points to document...

@kdy1 kdy1 merged commit 87b4e10 into swc-project:main Oct 22, 2024
152 of 154 checks passed
@unbyte unbyte deleted the fix/eval-rename branch October 22, 2024 11:30
kdy1 added a commit that referenced this pull request Oct 23, 2024
@kdy1
doc(contributing): Document changeset (#9667)
602c667 
Requested from #9666 (comment)
@kdy1 kdy1 modified the milestones: Planned, 1.7.38 Oct 26, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.7.40
Development

Successfully merging this pull request may close these issues.

helper set is incorrectly renamed when it needs protection
3 participants
@unbyte @CLAassistant @kdy1