Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ts/fast-strip): Support type-only/uninstantiated namespaces #9983

Merged
merged 5 commits into from
Feb 2, 2025
Merged

feat(ts/fast-strip): Support type-only/uninstantiated namespaces #9983

merged 5 commits into from
Feb 2, 2025
+333 −58

Conversation

magic-akari
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9a7f5fe

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magic-akari magic-akari marked this pull request as ready for review February 1, 2025 10:36
@magic-akari magic-akari requested a review from a team as a code owner February 1, 2025 10:36
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 1, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9983 will improve performances by 4.59%

Comparing magic-akari:fix/issue-9977 (9a7f5fe) with main (e9843d8)

Summary

⚡ 2 improvements
✅ 194 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ es/minifier/libs/lodash 205.7 ms 197.3 ms +4.28%
⚡ es/minifier/libs/moment 103.7 ms 99.1 ms +4.59%

robpalme
robpalme reviewed Feb 1, 2025
View reviewed changes
Copy link

@robpalme robpalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @magic-akari 👍

bindings/binding_typescript_wasm/__tests__/__snapshots__/transform.js.snap Show resolved Hide resolved
@kdy1 kdy1 added this to the Planned milestone Feb 1, 2025
@kdy1 kdy1 self-assigned this Feb 2, 2025
@kdy1
Copy link
Member

kdy1 commented Feb 2, 2025

About the parser issue, I didn't remember if there was a special reason for the current behavior, but the good point is that, it does not break Wasm plugins.

@kdy1 kdy1 enabled auto-merge (squash) February 2, 2025 02:53
@kdy1 kdy1 merged commit a72c6fa into swc-project:main Feb 2, 2025
171 checks passed
@acutmore
Copy link

acutmore commented Feb 3, 2025

Interesting! Are there any AST changes that are wasm-plugin ABI safe, or are all changes a breaking change?

@kdy1
Copy link
Member

kdy1 commented Feb 3, 2025

Renaming fields are ABI-safe but except that nearly every changes breaks ABI

@acutmore
Copy link

acutmore commented Feb 3, 2025

Thanks for the info, much appreciated @kdy1

@kdy1 kdy1 modified the milestones: Planned, v1.10.13 Feb 3, 2025
@magic-akari magic-akari deleted the fix/issue-9977 branch February 5, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robpalme robpalme robpalme left review comments

@marco-ippolito marco-ippolito marco-ippolito left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.10.13
Development

Successfully merging this pull request may close these issues.

@swc/wasm-typescript support type-only/uninstantiated namespaces
5 participants
@magic-akari @kdy1 @acutmore @robpalme @marco-ippolito