Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cargo): use lld for win x64 build #3683

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 22, 2022

Description:

This PR attempts to try new linker for the builds. As first step, replaces x64 windows build to use lld. Instead of using separate llvm installation for lld which can be verbose to setup this uses out-of-the box lld comes with rustc.

Consider this as an expriment, this may not improve performance drastically. Guess we can try & see.

BREAKING CHANGE:

Related issue (if exists):

@kwonoj
Copy link
Member Author

kwonoj commented Feb 22, 2022

note i686 doesn't do this - it fails to build.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • ''

@kdy1 kdy1 merged commit 82914d4 into swc-project:main Feb 22, 2022
@kdy1 kdy1 added this to the v1.2.144 milestone Feb 22, 2022
@yisibl
Copy link
Contributor

yisibl commented Mar 2, 2022

Is zld helpful for swc? bevyengine/bevy#312

@kwonoj kwonoj deleted the build-rust-lld-windows branch March 2, 2022 04:57
@kwonoj
Copy link
Member Author

kwonoj commented Mar 2, 2022

Zld and other (mold for example for linux) is in consideration, just couldn't spend time to setup CI & make it required for local dev. If there's poc shows meaningful gain we can definitely try.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants