Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bump rkyv #9716

Closed
wants to merge 6 commits into from
Closed

[WIP] bump rkyv #9716

wants to merge 6 commits into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 5, 2024

Description:

Trying to bump up rkyv, haven't able to resolve all of the breaking changes. Creating early to discuss further.

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 05386b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #9716 will not alter performance

Comparing kwonoj:bump-rkyv (05386b2) with main (aff9de5)

Summary

✅ 194 untouched benchmarks

@kdy1
Copy link
Member

kdy1 commented Nov 7, 2024

@kwonoj I fixed the bytecheck derive part. Can you continue working on deriving Portable for serializable types?

@kwonoj
Copy link
Member Author

kwonoj commented Nov 8, 2024

I'll try when I have some free time to spin.

@kdy1 kdy1 force-pushed the bump-rkyv branch 2 times, most recently from cd1352e to d19d2c0 Compare November 8, 2024 05:27
@kdy1
Copy link
Member

kdy1 commented Nov 8, 2024

@kwonoj Can you help me rebasing? Actually I had time to proceed but not sure about how I should rebase this PR.

@kwonoj
Copy link
Member Author

kwonoj commented Nov 8, 2024

Thanks, rebase seems bit confused. Looks like now there's an error regarding constraint to Portable.

@kdy1 kdy1 closed this in #9730 Nov 11, 2024
kdy1 added a commit that referenced this pull request Nov 11, 2024
**Related issue:**

 - Closes #9716

---------

Co-authored-by: OJ Kwon <1210596+kwonoj@users.noreply.github.com>
@kwonoj kwonoj deleted the bump-rkyv branch November 11, 2024 05:17
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants