Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is multiworkspace supported? #193

Open
sweetim opened this issue Mar 18, 2022 · 4 comments
Open

is multiworkspace supported? #193

sweetim opened this issue Mar 18, 2022 · 4 comments

Comments

@sweetim
Copy link

sweetim commented Mar 18, 2022

i have workspace that contains a mixture of rust and non rust projects, in the test explorer it displays a list of drop down, but each drop down contains no test items

image

@calebcartwright
Copy link
Member

Are you referring to multi root workspaces? If so, I believe the answer is still no, although if you have a minimal repro that could be used to reproduce that would be helpful as well

@sweetim
Copy link
Author

sweetim commented Mar 19, 2022

yes, multi root workspaces

there are 2 problems
i) when new rust workspace is added, it will break the test explorer (as reported above)
ii) if non rust is included in workspace, it displays duplicated test cases from other rusts workspace

Reproduce for (i)

  • create 2 rust folder (with tests or without tests)
  • add both of the folder into workspace, and the rust explorer will break

Reproduce for (ii)

  • add any non rust folder into the workspace, the test explorer will duplicate the same test cases from other rust folder

@calebcartwright
Copy link
Member

add both of the folder into workspace, and the rust explorer will break

Could you define "break" more concretely? As I alluded to in my prior comment we don't expect multiroot workspaces to be supported, but break can mean different things (e.g. simply not detecting/loading tests vs. logging errors vs. crashing vs. etc.)

@sweetim
Copy link
Author

sweetim commented Mar 26, 2022

break in that statement means all the workspace are named as rust in the test explorer, and when click on each drop down it displays nothing

will wait for the release of multi root workspace support, maybe it is good to add a description in the README.md that explicitly inform user that the multi root workspace is not supported yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants