Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to specify toolchain #50

Open
calebcartwright opened this issue Oct 8, 2019 · 4 comments
Open

Add config option to specify toolchain #50

calebcartwright opened this issue Oct 8, 2019 · 4 comments
Labels
enhancement New feature or request
Projects
Milestone

Comments

@calebcartwright
Copy link
Member

I'll often use rustup override to explicitly set the toolchain to use in a project directory (particularly for projects like rustfmt and clippy that often need a specific nightly version), but the cargo commands we're invoking in a newly spawned process for test discovery/execution don't seem to be picking that up.

I suspect that adding a rust-toolchain file would work, though I don't think we should fail to work without one. Let's add a config option to allow explicitly specifying toolchain

@calebcartwright calebcartwright added the enhancement New feature or request label Oct 8, 2019
@calebcartwright calebcartwright added this to To do in 1.x Release via automation Nov 13, 2019
@calebcartwright calebcartwright moved this from To do to In progress in 1.x Release Nov 13, 2019
@calebcartwright calebcartwright added this to the 1.x Release milestone Nov 13, 2019
@calebcartwright calebcartwright added the wip Work is in progress label Nov 13, 2019
@calebcartwright calebcartwright self-assigned this Nov 13, 2019
@JRAndreassen
Copy link

JRAndreassen commented Aug 10, 2020

I have the same issue...

It seems to not honor the directives in the "toolchain" file in the project directory...
Do you run the cargo command from the directory or direct reference ?

The issue when to a workspace cargo.toml in the parent...
cwd is set to parent dir, location of the workspace toml...

@calebcartwright calebcartwright removed the wip Work is in progress label Aug 10, 2020
@calebcartwright calebcartwright removed their assignment Aug 10, 2020
@calebcartwright
Copy link
Member Author

It seems to not honor the directives in the "toolchain" file in the project directory...

Would you please open a new issue? This issue is primarily about adding a config option, and I would prefer to debug any issues you are having in a separate, dedicated issue.

Do you run the cargo command from the directory or direct reference ?

The cargo invocations are executed in the directory of the corresponding Cargo.toml as needed. In the case of cargo test... commands, these are executed in the same directory of the Cargo.toml file for the respective package, regardless of whether it's a single package project or a workspace project.

const execArgs: ExecOptions = {
cwd: targetWorkspace,
maxBuffer
};

The issue when to a workspace cargo.toml in the parent...
cwd is set to parent dir, location of the workspace toml...

Sorry, I have no idea what you're trying to say there.

@JRAndreassen

This comment has been minimized.

@calebcartwright

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
1.x Release
  
In progress
Development

No branches or pull requests

2 participants