add functions for getting metadata about a specific person #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: filter db by date fix: notebook
rename unittest workflow
…or a full protocol
…ncludes no text sequences
…nto add_context_functions
add context sequence functions
ninpnin
requested changes
Oct 30, 2024
pyriksdagen/utils.py
Outdated
| @@ -26,6 +26,10 @@ | |||
| XML_NS = "{http://www.w3.org/XML/1998/namespace}" | |||
| TEI_NS = "{http://www.tei-c.org/ns/1.0}" | |||
|
|
|||
| def fetch_ns(): | |||
| return {"tei_ns": "{http://www.tei-c.org/ns/1.0}", | |||
There was a problem hiding this comment.
I use namespaces as a dict object all over the project. Would you be happy with a compromise?
def fetch_ns():
return {"tei_ns": TEI_NS,
"xml_ns": XML_NS}
…en into fetch-meta-vars
ninpnin
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev