Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quick Navigation] When typing in the filter bar, pressing '/' incorrectly shows the Quick Navigation modal #410

Closed
1 task done
franklinsch opened this issue Aug 11, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@franklinsch
Copy link
Contributor

franklinsch commented Aug 11, 2022

Description

When using the navigator filter bar to look up a symbol, pressing '/' probably shouldn't invoke the modal if you're actually looking for a symbol with the / character within in. Maybe when the filter bar is focused, '/' shouldn't invoke the Quick Navigation modal at all.

Checklist

Expected Behavior

No response

Actual behavior

No response

Steps To Reproduce

  1. Navigate to https://sofiaromorales.github.io/swift-argument-parser/documentation/argumentparser
  2. Start typing in the navigator sidebar's filter bar.
  3. Enter '/'

Swift-DocC-Render Version Information

No response

@franklinsch franklinsch added the bug Something isn't working label Aug 11, 2022
@mportiz08
Copy link
Contributor

\cc @sofiaromorales

@sofiaromorales
Copy link
Contributor

addressed by #396

@ethan-kusters
Copy link
Contributor

@franklinsch @sofiaromorales can we close this out?

@marinaaisa
Copy link
Member

@franklinsch @sofiaromorales can we close this out?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants