Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new typeDetails symbol mixin #56

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

pdwilson12
Copy link
Contributor

@pdwilson12 pdwilson12 commented Mar 31, 2023

Bug/issue #, if applicable: rdar://107432025

Summary

Add new typeDetails symbol mixin to hold type details of weakly-typed dictionary keys and HTTP parameters.
JSON structures and HTTP parameters can define fields that can take values of multiple types,
such as integers or strings. The typeDetails mixin allows the symbol graph to identify the individual types that are supported. DocC will use this information to list the "Possible types" in the rendered pages for the affected keys and parameters.

Dependencies

None.

Testing

To be described in parallel DocC PR.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@pdwilson12
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pdwilson12
Copy link
Contributor Author

@swift-ci please test

@pdwilson12 pdwilson12 merged commit 53e5cb9 into swiftlang:main Mar 31, 2023
@pdwilson12 pdwilson12 deleted the type_details branch March 31, 2023 22:55
pdwilson12 added a commit to pdwilson12/swift-docc-symbolkit that referenced this pull request Mar 31, 2023
…ed dictionary keys and HTTP parameters. (swiftlang#56)

Co-authored-by: Peter Wilson <pwilson@apple.com>
pdwilson12 added a commit that referenced this pull request Apr 1, 2023
…ed dictionary keys and HTTP parameters. (#56) (#57)

Co-authored-by: Peter Wilson <pwilson@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants