From 9eb1c446b9aee5f6b0f6aa1d1010b4a37f05a9d3 Mon Sep 17 00:00:00 2001 From: Evan Wilde Date: Wed, 3 Nov 2021 12:29:22 -0700 Subject: [PATCH] Disabling noisy readonly fs test This patch disables the readonly fs indexing test due to the CI noise and potential to leak resources on failures. --- Tests/SwiftDocCTests/Indexing/NavigatorIndexTests.swift | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Tests/SwiftDocCTests/Indexing/NavigatorIndexTests.swift b/Tests/SwiftDocCTests/Indexing/NavigatorIndexTests.swift index 0eb0dc5669..1bb202336a 100644 --- a/Tests/SwiftDocCTests/Indexing/NavigatorIndexTests.swift +++ b/Tests/SwiftDocCTests/Indexing/NavigatorIndexTests.swift @@ -1129,8 +1129,13 @@ Root XCTAssertEqual(PageType(symbolKind: "intfopfunc"), PageType(symbolKind: "func.op")) XCTAssertEqual(PageType(symbolKind: "intftdef"), PageType(symbolKind: "associatedtype")) } - - func testNavigatorIndexOnReadOnlyFilesystem() throws { + + // rdar://84986427 + // Mounting and unmounting the dmg creates noise on the bots when it fails. + // If the test fails before unmounting, the resource is leaked. + // This is currently the only test mounting anything, but with tests running + // in parallel, this could cause collisions. + func skip_testNavigatorIndexOnReadOnlyFilesystem() throws { #if os(macOS) // To verify we're able to open a read-only index, we need to mount a small DMG in read-only mode. let dmgPath = Bundle.module.url(