Add request argument to opt-out of source file path information #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://107075861
|
@swift-ci please test |
ethan-kusters
approved these changes
Mar 31, 2023
d-ronnqvist
added a commit
to d-ronnqvist/swift-docc
that referenced
this pull request
Mar 31, 2023
d-ronnqvist
added a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://107075861
Summary
This adds an argument to ConvertRequest to allow opting out of source file URI information for requests that don't need or want that information.
Dependencies
None
Testing
Generate documentation for a symbol using the ConvertService API and configure
emitSymbolSourceFileURIstofalsein the request.The render node in the response should not have its metadata.remoteSource property set.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded