[5.9] Process typeDetails information from symbol graphs
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Process `typeDetails` information from symbol graphs. Convert data into base-type details and allowed type declarations for `RenderProperty` entities, such as dictionary keys and HTTP parameters. * Update SymbolKit dependency to pick up latest commit.
|
@swift-ci please test |
sara-radi
approved these changes
Apr 1, 2023
pdwilson12
force-pushed
the
type_details_5.9
branch
from
e577cfd
to
a8778a7
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #529
Explanation: HTTP/REST requests and JSON dictionaries can define parameters and keys that are weakly typed, allowing for multiple possible value types, such as integer or string. This extends symbol graphs to call out those individual allowed types and show up on the rendered page.
Scope: Adds a new optional key to symbol graphs and converts that data to existing page structures used when rendering HTTP parameters and dictionary keys.
Radar: rdar://107432025
Risk: Low. Added key is optional.
Testing: Changes are covered by unit tests.
Reviewer: @QuietMisdreavus