Use URL.resourceValues() for symlink detection (#428)

This should provide a significant performance improvement on macOS. See [this](#400 (comment)]) for more discussion on non-macOS platforms. Co-authored-by: Pyry Jahkola <pyry.jahkola@iki.fi>
swiftlang · Aug 15, 2023 · c110bd1 · c110bd1
1 parent 7963ebc
commit c110bd1
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Sources/TSCBasic/FileSystem.swift b/Sources/TSCBasic/FileSystem.swift
@@ -383,8 +383,10 @@ private struct LocalFileSystem: FileSystem {
     }
 
     func isSymlink(_ path: AbsolutePath) -> Bool {
-        let attrs = try? FileManager.default.attributesOfItem(atPath: path.pathString)
-        return attrs?[.type] as? FileAttributeType == .typeSymbolicLink
+        let url = NSURL(fileURLWithPath: path.pathString)
+        // We are intentionally using `NSURL.resourceValues(forKeys:)` here since it improves performance on Darwin platforms.
+        let result = try? url.resourceValues(forKeys: [.isSymbolicLinkKey])
+        return (result?[.isSymbolicLinkKey] as? Bool) == true
     }
 
     func isReadable(_ path: AbsolutePath) -> Bool {