Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] path: drop the trailing backslash before invoking PathCchRe… #479

Merged
merged 2 commits into from
Aug 5, 2024
Merged

[windows] path: drop the trailing backslash before invoking PathCchRe… #479

merged 2 commits into from
Aug 5, 2024

Commits on Aug 2, 2024

  1. [windows] path: drop the trailing backslash before invoking PathCchRe… 

    …moveFileSpec to compute the dirname

PathCchRemoveFileSpec's is documented to not remove the file spec if it comes with a backslash suffix. Thus, we should remove the trailing backslashes before calling this API, to ensure we actually drop the current file/directory name
    @hyp
    hyp committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    aa6245b View commit details
    Browse the repository at this point in the history

  2. Test C:\\\ case

    @hyp
    hyp committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    53cabc8 View commit details
    Browse the repository at this point in the history