Avoid AnyView in the Counter code #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed there as `ViewBuilder` is smarter now.
MaxDesiatov
requested review from
carson-katri and
j-f1
and removed request for
carson-katri and
j-f1
carson-katri
reviewed
Jul 7, 2020
| @@ -45,15 +45,16 @@ struct Counter: View { | |||
| let limit: Int | |||
|
|
|||
| var body: some View { | |||
There was a problem hiding this comment.
I think you need @ViewBuilder here
There was a problem hiding this comment.
Yes, I forgot to commit it 🤦♂️
There was a problem hiding this comment.
No longer needed as @ViewBuilder is already on the body declaration of the View protocol.
|
Huh, so applying this change actually introduces crashes similar to #167. There definitely is some incompatibility between UPDATE: the runtime library is not related, this was an infinite recursion problem. |
…nter # Conflicts: # Sources/TokamakDOM/Shapes/Path.swift
carson-katri
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed there as
ViewBuilderis smarter now.The macOS SwiftUI SDK even with Xcode 12 still doesn't have the
@ViewBuilderattribute on theViewprotocol, so we have to build for iOS on CI to make the native buld pass.Resolves #167, which wasn't caused by protocol conformance problems, but by infinite recursion in the
_ConditionalContentimplementation ofbody.Adds assorted formatting fixes, some are apparently caused by the newer
swiftformatversion.