Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize all the re-exports into a single file #193

Merged
merged 2 commits into from
Jul 19, 2020
Merged

Organize all the re-exports into a single file #193

merged 2 commits into from
Jul 19, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Jul 18, 2020

Hypothetically, Core.swift could be copy-pasted unmodified into any renderer.

@j-f1
Organize all the re-exports into a single file
1d7b05b 
Hypothetically, Core.swift could be copy-pasted unmodified into any renderer
@j-f1 j-f1 added the refactor No user-visible functionality change label Jul 18, 2020
@ie-ahm-robox
Copy link
Collaborator

Fails
🚫

Sources/TokamakDOM/Views/ZStack.swift#L36 - Line should be 100 characters or less: currently 101 characters (line_length)

Generated by 🚫 Danger Swift against 1d7b05b

MaxDesiatov
MaxDesiatov approved these changes Jul 18, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@j-f1 j-f1 requested a review from carson-katri July 18, 2020 16:40
@j-f1 j-f1 merged commit 743d9a0 into main Jul 19, 2020
@j-f1 j-f1 deleted the re-exports branch July 19, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carson-katri carson-katri carson-katri approved these changes

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
refactor No user-visible functionality change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-f1 @ie-ahm-robox @MaxDesiatov @carson-katri