Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UIColor stub and new Color.init(_:UIColor) #196

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Add UIColor stub and new Color.init(_:UIColor) #196

merged 1 commit into from
Jul 21, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Jul 20, 2020 •
edited
Loading

It doesn't strictly follow the UIColor API, but does the job of resolving the linked issue. Maybe another UIColor initializer could be added in the future if requested, but I think we now cover the most common case.

Resolves #186.

@MaxDesiatov MaxDesiatov added the SwiftUI compatibility Tokamak API differences with SwiftUI label Jul 20, 2020
@MaxDesiatov MaxDesiatov requested review from carson-katri and j-f1 July 20, 2020 16:31
@MaxDesiatov MaxDesiatov merged commit 5ebf5a5 into main Jul 21, 2020
@MaxDesiatov MaxDesiatov deleted the uicolor branch July 21, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

@carson-katri carson-katri carson-katri approved these changes

Assignees
No one assigned
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set Color value
3 participants
@MaxDesiatov @carson-katri @j-f1