Add DefaultApp type to simplify DOMRenderer.init
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
changed the title
DefaultApp type to simplify DOMRenderer.initDefaultApp type to simplify DOMRenderer.init
|
The only concern I have is that the body tag will have its styles overridden when you’re just rendering a View. Before this wasn’t the case, so you could embed tokamak in an existing project w/o it affecting any of your existing styles. Maybe add a flag to check in launch if the body styles should be added or not? |
MaxDesiatov
commented
Jul 27, 2020
| let body = TokamakDOM.body | ||
| if body.style == .undefined { | ||
| body.style = "margin: 0;" | ||
| } |
There was a problem hiding this comment.
@carson-katri what do you think about this check?
carson-katri
approved these changes
Jul 27, 2020
j-f1
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the
Viewinitializer ofDOMRenderernow can delegate to theAppinitializer by creating a wrappingDefaultApp. It would simplify #136 for me, where I no longer need to implement color scheme observation for these two different codepaths separately.