Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building a test bundle fails with 5.3 snapshots #1824

Closed
MaxDesiatov opened this issue Sep 24, 2020 · 4 comments · Fixed by swiftwasm/swift-corelibs-foundation#143
Closed

Building a test bundle fails with 5.3 snapshots #1824

MaxDesiatov opened this issue Sep 24, 2020 · 4 comments · Fixed by swiftwasm/swift-corelibs-foundation#143
Assignees
@kateinoigakukun
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link

MaxDesiatov commented Sep 24, 2020 •
edited
Loading

The error is raised by wasm-ld:

wasm-ld: error: 
/Users/maxd/.carton/sdk/wasm-5.3-SNAPSHOT-2020-09-23-a/usr/share/wasi-sysroot/lib/wasm32-wasi/
libc.a(__original_main.o): undefined symbol: main

The build command is

/Users/maxd/.carton/sdk/wasm-5.3-SNAPSHOT-2020-09-23-a/usr/bin/swift \
  build -c debug --build-tests --destination /Users/maxd/.carton/sdk/wasm-5.3-SNAPSHOT-2020-09-23-a.json -Xswiftc -color-diagnostics
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 24, 2020
@MaxDesiatov
Copy link
Author

MaxDesiatov commented Sep 24, 2020 •
edited
Loading

Looks like we don't have any 5.3 snapshots where tests link successfully. The latest development snapshot that doesn't have this bug is wasm-DEVELOPMENT-SNAPSHOT-2020-08-11-a. wasm-DEVELOPMENT-SNAPSHOT-2020-09-23-a fails to link with libFoundation.a(Data.swift.obj): undefined symbol: _withStackOrHeapBuffer.

@MaxDesiatov MaxDesiatov mentioned this issue Sep 24, 2020
Closed
11 tasks
@MaxDesiatov MaxDesiatov changed the title Building a test bundle fails with the latest 5.3 snapshot Building a test bundle fails with 5.3 snapshots Sep 24, 2020
@MaxDesiatov MaxDesiatov mentioned this issue Sep 24, 2020
Merged
@kateinoigakukun kateinoigakukun self-assigned this Sep 25, 2020
@kateinoigakukun
Copy link
Member

This will be fixed by cherry-picking @MaxDesiatov 's commit swiftwasm/swift-package-manager@a36331a

It's just a forgetting of cherry-picking from master branch.

@MaxDesiatov
Copy link
Author

Thanks a lot for picking this up, and sorry I forgot about that patch 😅

@MaxDesiatov
Copy link
Author

I confirm that it was fixed in wasm-5.3-SNAPSHOT-2020-09-25-a.

@kateinoigakukun kateinoigakukun mentioned this issue Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kateinoigakukun kateinoigakukun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WASM] Restore lost _withStackOrHeapBuffer implementation swiftwasm/swift-corelibs-foundation
2 participants
@MaxDesiatov @kateinoigakukun