Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers to request methods in DocumentClient(Interface) #34

Merged
merged 1 commit into from
Dec 25, 2018
Merged

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Dec 25, 2018

Description

I added a headers param to the request methods of DocumentClientInterface.

Motivation and context

Some requests require extra headers. fixes #33

How has this been tested?

Tested in a real life project as we currently have no tests for the DocumentClient.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo merged commit f0ac206 into master Dec 25, 2018
@JaZo JaZo deleted the issue/33 branch December 25, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability set dynamic headers per request
1 participant