add isSuccess method to Document #40

Fivell · 2019-01-07T16:00:11Z

just for alternative usage of else/if statement after document initialization

allows hadle success block in if statement in more readable way

before

if !($document->hasErrors()){ ... }

after

if $document->isSuccess() { ... }

Description

add new method to Document class

Motivation and context

allows to check Document instance is successful

How has this been tested?

Unit test

just for alternative usage of else/if statement after document initialization allows hadle success block in if statement in more readable way before ``` if !($document->hasErrors()){ ... } ``` after ``` if $document->isSuccess() { ... } ```

JaZo · 2019-01-11T09:00:52Z

Thanks!

add isSuccess method to Document

c0729e7

just for alternative usage of else/if statement after document initialization allows hadle success block in if statement in more readable way before ``` if !($document->hasErrors()){ ... } ``` after ``` if $document->isSuccess() { ... } ```

Fivell force-pushed the add_is_success_method branch from e606b91 to c0729e7 Compare January 7, 2019 16:14

JaZo merged commit f854fc0 into swisnl:master Jan 11, 2019

Fivell deleted the add_is_success_method branch January 11, 2019 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add isSuccess method to Document #40

add isSuccess method to Document #40

Fivell commented Jan 7, 2019 •

edited

Loading

JaZo commented Jan 11, 2019

add isSuccess method to Document #40

add isSuccess method to Document #40

Conversation

Fivell commented Jan 7, 2019 • edited Loading

Description

Motivation and context

How has this been tested?

JaZo commented Jan 11, 2019

Fivell commented Jan 7, 2019 •

edited

Loading