Do not throw exceptions in Repository #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed the exceptions from
Repository
and added tests for it.Motivation and context
The repository only throwd exceptions in some use cases (GET requests) which was not consistent with other use cases. Besides, the repository consumer might want to handle errors differently, but because of the current implementation, he/she has no access to the underlying document. By removing the exceptions, the consumer can implement any check he/she wants. The old behaviour can be recreated by simply extending the repository and implementing the checks yourself. This closes #39.
How has this been tested?
Tested using new unit tests.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.