Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure dissociating a related item results in valid JSON #42

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Jan 11, 2019

Description

I changed the serialization logic so it produces valid JSON when dissociating related items and I removed setting an [relationship]_id attribute when associating a related item.

Motivation and context

Dissociating a related item results in invalid JSON as discussed in #36. Besides, the HasOne relation sets a [relationship]_id field on the parent when associating a related item, but this is not required according to the spec. This fixes #36.

How has this been tested?

Tested using existing and new unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo merged commit 97a34fc into master Jan 11, 2019
@JaZo JaZo deleted the issue/36 branch January 11, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json-api-client breaks serialization when working with associations
1 participant