Make sure dissociating a related item results in valid JSON #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the serialization logic so it produces valid JSON when dissociating related items and I removed setting an
[relationship]_id
attribute when associating a related item.Motivation and context
Dissociating a related item results in invalid JSON as discussed in #36. Besides, the HasOne relation sets a
[relationship]_id
field on the parent when associating a related item, but this is not required according to the spec. This fixes #36.How has this been tested?
Tested using existing and new unit tests.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.