Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta and links #47

Merged
merged 21 commits into from
Feb 20, 2019
Merged

Meta and links #47

merged 21 commits into from
Feb 20, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Feb 12, 2019

Description

I've added meta and links to all objects that can have them.

Motivation and context

Meta and links were only partially implemented.

How has this been tested?

Tested using existing and new unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo added the enhancement New feature or request label Feb 12, 2019
@JaZo JaZo requested a review from HendrikN February 12, 2019 13:20
Copy link

@HendrikN HendrikN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@JaZo JaZo merged commit 6972d7f into master Feb 20, 2019
@JaZo JaZo deleted the feature/meta-and-links branch February 20, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants