Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom Response #48

Merged
merged 3 commits into from
Mar 12, 2019
Merged

Drop custom Response #48

merged 3 commits into from
Mar 12, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Mar 12, 2019

Description

I've removed the custom ResponseInterface and Response class and added the response to the DocumentInterface.

Motivation and context

The custom response was a useless wrapper around a PSR-7 response and the current setup does not give access to the underlying response to check e.g. headers or status codes.

How has this been tested?

Tested with new/updated unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo merged commit 8cd1cf8 into master Mar 12, 2019
@JaZo JaZo deleted the feature/drop-custom-response branch March 12, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant