Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.8 support #50

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Laravel 5.8 support #50

merged 3 commits into from
Mar 19, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Mar 19, 2019

Description

I've added support for Laravel 5.8.

Motivation and context

Laravel 5.8 is out and about! I had to drop PHP <7.1 and Laravel <5.5 support in order to make it compatible. But since these are both EOL, I think it is appropriate to do so!

closes #49

How has this been tested?

Tested with existing unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@bbrala
Copy link
Member

bbrala commented Mar 19, 2019

Think older the older testbench/phpunit dependency is still needed for Laravel 5.5.

@JaZo JaZo force-pushed the feature/laravel-5.8 branch from fd35019 to 958dd81 Compare March 19, 2019 14:17
@JaZo JaZo merged commit b90340b into master Mar 19, 2019
@JaZo JaZo deleted the feature/laravel-5.8 branch March 19, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Laravel 5.8 support
2 participants