Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor both DocumentBuilders to one DocumentFactory #52

Merged
merged 3 commits into from
Jul 5, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Jul 4, 2019

Description

I dropped both DocumentBuilders and created a DocumentFactory that makes an ItemDocument or CollectionDocument based on the data you give it. The factory doesn't hydrate the items anymore, that's up to the ItemHydrator. It does gather the included itself based on the relations of the item(s) instead of asking the item for the items that should be included.

Motivation and context

This should improve the code quality by moving some logic to the responsible class and simplifying the Item (currently the worst rated class according to Scrutinizer).

How has this been tested?

Tested with updated unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo requested a review from HendrikN July 4, 2019 10:55
src/DocumentFactory.php Show resolved Hide resolved
src/DocumentFactory.php Outdated Show resolved Hide resolved
src/Item.php Show resolved Hide resolved
src/Item.php Show resolved Hide resolved
@JaZo JaZo force-pushed the feature/refactor-document-builders branch from 29b047e to 04f58f6 Compare July 4, 2019 14:38
@JaZo JaZo force-pushed the feature/refactor-document-builders branch from 04f58f6 to f097242 Compare July 4, 2019 15:00
@JaZo JaZo merged commit 2b6901a into master Jul 5, 2019
@JaZo JaZo deleted the feature/refactor-document-builders branch July 5, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants