Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality and test coverage of Item #53

Merged
merged 6 commits into from
Jul 9, 2019
Merged

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Jul 5, 2019

Description

I've split Item into several traits/concerns to group some logic together and make the class cleaner. All concerns have tests. Besides that, I added some missing tests for other classes as well.

I also renamed some methods to align all method names and make them less confusing. This is a (documented) breaking change.

Motivation and context

This should increase the code quality and test coverage of Item and some other classes.

How has this been tested?

Tested with new and updated unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo requested a review from HendrikN July 5, 2019 15:34
@JaZo JaZo merged commit 3003245 into master Jul 9, 2019
@JaZo JaZo deleted the feature/improve-item branch July 9, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants