Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I refactored the
Parser
andHydrator
into several smaller classes similar to the existing parsers. This should improve the code quality and lower the complexity. Besides that, I made sure everything is properly tested. This is a breaking change if you use one of the parsers yourself instead of the repository.An important change to note is that relationships with data that is not included in the document are now also hydrated as empty Item.
Given
Before
After
Motivation and context
The
Parser
andHydrator
are fairly complex and tightly coupled. Besides that, test coverage was poor.How has this been tested?
Test using new and existing unit tests.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.