Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra verifications for links #59

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Jul 24, 2019

Description

  • Self and related links can no longer be null.
  • Some links objects MUST now have certain links if a links object is present:
    Error: about
    Relationship: self or related

Motivation and context

According to the spec, self and related links can not be null, only pagination links can be.

Spec for error: https://jsonapi.org/format/#error-objects
Spec for relationship: https://jsonapi.org/format/#document-resource-object-relationships

How has this been tested?

Tested with new and updated unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

JaZo added 2 commits July 24, 2019 14:04
Some links objects, depending on their source/parent, MUST have specific links.
@JaZo JaZo merged commit c693173 into master Jul 24, 2019
@JaZo JaZo deleted the bugfix/not-all-links-can-be-null branch July 24, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant