Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require error links object to contain an about member #69

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Nov 21, 2019

Description

See title.

Motivation and context

The spec isn't unambiguous about whether the error links object MUST contain an about member or not. We interpreted it as such, but I believe we should remove the restriction for now until it is clarified.

Closes #68

How has this been tested?

N/A

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinksParser: Handle and debug error response when bad params are passed in filters / fields ecc.
1 participant