Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not break out of loop when hydrating relations #71

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Dec 2, 2019

Description

I fixed a bug where the ItemHydrator does not hydrate relations following a relation that needs to be dissociated.

Motivation and context

Bug introduced in #67

How has this been tested?

Tested with added unit test.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

Copy link

@marijnz0r marijnz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, this fixes my issue!

@JaZo JaZo merged commit 9379ad5 into master Dec 2, 2019
@JaZo JaZo deleted the bugfix/item-hydrator-unset-relation-fix branch December 2, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants