Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw JsonExceptions on errors in all json_encode and json_decode calls #94

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Oct 15, 2021

Description

All json_encode and json_decode calls now throw JsonExceptions on error.

Motivation and context

This will harden the error handling and make sure no incorrect/partial output is used.

How has this been tested?

Existing tests already cover a case of invalid JSON.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added/updated tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo merged commit 9d6b4ed into master Oct 15, 2021
@JaZo JaZo deleted the feature/throw-json-exceptions branch October 15, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant